Two fixes to multi repl command #10017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
May 16, 2024
|
Let me rebase, since all the CI fixes have now landed. |
|
@mergify rebase |
✅ Branch has been successfully rebased |
|
Any chance for some tests? |
Kleidukos
approved these changes
May 25, 2024
mpickering
force-pushed
the
wip/multi-fixes
branch
2 times, most recently
from
1c0593d
to
d8ad5dc
Compare
|
I have added a test now. |
|
Wonderful. Let me set the merge label so that we can backport sooner. |
mergify
bot
added
the
merge delay passed
These options are configured into the program by Cabal, so we also need to extract these and put them into the mutli-file. Fixes haskell#10015
Before this was rendered as.. ``` /run/current-system/sw/bin/ghc --interactive -package-env - -j 'NumJobs (Just 8)' ... ``` Due to this place not being updated when support for semaphores was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc-optionsfor example)-jwhen finally invoking the replBoth should be backported to 3.12 release