one last changelog entry

[geekosaur]

This was on master but missing from 3.12.

[ulysses4ever]

I wonder why the bot doesn't act on this one

[geekosaur]

It hasn't acted on the original changelog PR either.

I just checked the Mergify rules, and I'm not sure it ever runs on these. There are commit rules for master and there are commit rules for not-master when the body contains "backport".

[geekosaur]

Ugh, and the Mergify rules on 3.12 branch don't support squash+merge me. Did we not backport that?

[geekosaur]

We didn't. It had the "backport to 3.12" label, which @Mikolaj removed shortly after it was committed.

[ulysses4ever]

Great investigation, thanks! Do you think we should merge manually? That would be fine I think. Would be great to extend Mergify config one day...

[geekosaur]

A quick look at past changelogs shows they were updated on master and backported. I guess we need to merge these by hand.

But this is making me wonder how many other things that should have been backported weren't.

[geekosaur]

I'll work on Mergify config after the release. For now, I'm merging manually.

[Mikolaj]

Note: this is in relation to #10132 (comment).

We didn't. It had the "backport to 3.12" label, which @Mikolaj removed shortly after it was committed.

Uhoh. Which PR was that? Let me at least try to find any other backport labels I removed that day.

[geekosaur]

#9879
As it turns out, it doesn't matter for that PR because Mergify only pays attention to .github/mergify.yml in master. I'm still worried about what other PRs we might be missing, though.

[Mikolaj]

Thanks. I will have a closer look at my routine from that time, later on.