Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower memory usage during index file parsing #2396 #2826

Merged
merged 4 commits into from Sep 18, 2015
Merged

Lower memory usage during index file parsing #2396 #2826

merged 4 commits into from Sep 18, 2015

Commits on Jun 17, 2015

  1. #2396 fix proof of concept

    @sznurek
    sznurek committed Jun 17, 2015
    Copy the full SHA
    fbf2298 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2015

  1. Made parsePackageIndex and updatePackageIndexCacheFile streaming. 

    The parsePackageIndex wasn't streaming because resulting list was
hidden in two constructors: Either and tuple. By removing that error
semantics changed in updatePackageIndexCacheFile.

The updatePackageIndexCacheFile problem was sequence call that evaluated
whole list made by parsePackageIndex. By using lazySequence any error
during index file parsing will be raised during writing to cache file.

Also removed reacPackageIndexFile, as it wasn't used anywhere as far as
I can tell. If this is a mistake I'll include it again.
    @sznurek
    sznurek committed Sep 17, 2015
    Copy the full SHA
    54e1ed2 View commit details
    Browse the repository at this point in the history

  2. Removed commented out export line.

    @sznurek
    sznurek committed Sep 17, 2015
    Copy the full SHA
    ef9c0e9 View commit details
    Browse the repository at this point in the history

  3. Removed reduntant imports.

    @sznurek
    sznurek committed Sep 17, 2015
    Copy the full SHA
    deb0934 View commit details
    Browse the repository at this point in the history