Fix #3345 by having Install manually register packages #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
force-pushed
the
pr/T3345
branch
2 times, most recently
from
3e90741
to
e5e96e0
Compare
ghost
mentioned this pull request
| cabal sandbox init | ||
| cabal sandbox add-source custom | ||
| cabal sandbox add-source client | ||
| # Set HOME to something goofy so that we force the user |
There was a problem hiding this comment.
Can't you just use --package-db=clear --package-db=global?
There was a problem hiding this comment.
No, that does not work, because these settings don't apply to Setup.hs build.
$ ghc-pkg-7.6 list
/opt/ghc/7.6.3/lib/ghc-7.6.3/package.conf.d
Cabal-1.16.0
/home/ezyang/.ghc/x86_64-linux-7.6.3/package.conf.d
Cabal-1.22.3.0
Cabal-1.23.0.0
Cabal-1.23.1.0
Cabal-1.23.2.0
$ cabal configure -v --package-db=clear --package-db=global -w ghc-7.6
...
/srv/prod/bin/ghc-7.6 --make -odir ./dist/setup -hidir ./dist/setup -i -i. -package-id Cabal-1.22.3.0-9afd7fdd87eadc07ff9f73c86e22d4fe ./dist/setup/setup.hs -o ./dist/setup/setup -threaded
I'll add a comment to this effect.
|
/cc @dcoutts |
|
Having cabal call setup to get the package reg info and then doing the registration ourselves is in principle the right thing to do (and what the new-build code does). I've not looked at the code in detail, but it's the right strategy. @23Skidoo so if you're happy with the code details then go for it. |
|
Yes, LGTM. @ezyang, feel free to merge the last commit. |
|
We can't merge this without also merging #3355 (otherwise the patch needs to be substantially reworked.) |
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
…cated. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Unfortunately, it was too difficult to factor out the common code between ProjectBuilding and Install. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the last commit.