Timer osx pr #3998
Merged
Timer osx pr #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still use os x 10.10 and GHC 7.8.4! |
|
Cunning! (don't take this as a code reivew, I don't know this stuff well enough) |
23Skidoo
approved these changes
Oct 18, 2016
| echo "$* took $duration seconds." | ||
| echo "whole job took $total_duration seconds so far." | ||
|
|
||
| # Terminate on OSX |
There was a problem hiding this comment.
Would be nice to mention that we're doing this to populate the cache.
|
Evil. :) But I ran out of disk space even when I just tried a simplified version of the build; let us see if the same problem shows up here. |
ezyang
reviewed
Oct 18, 2016
|
|
||
| # Terminate on OSX | ||
| if [ $total_duration -ge 2400 -a $(uname) = "Darwin" ]; then | ||
| echo "Job taking over 40 minutes. Terminating" |
There was a problem hiding this comment.
Yeah, it would be good if this told the person to rerun the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if osx build is too slow, it will cut it down, making the cache populate. So restarting the job would help!