Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark 'ghc-boot-th' as non-installable. #4949

Closed
wants to merge 1 commit into from

Conversation

23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Dec 11, 2017

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@angerman
Copy link
Collaborator

Ah! I didn't even know we had this! Would this mean, that if I pushed flags through all dependencies, cabal would never try to rebuild those packages? (E.g. related to #4939).

Coincidentally there was a discussion on #hackage today with @sclv and @hvr where the question cam up if ghc --info should just list the non-reinstallable packages.

GHC basically knows about

wiredInUnitIds :: [UnitId]
wiredInUnitIds = [ primUnitId,
                       integerUnitId,
                       baseUnitId,
                       rtsUnitId,
                       thUnitId,
                       thisGhcUnitId,
                       dphSeqUnitId,
                       dphParUnitId ]

as being wired in packages.

Anyway, this is only tangential to this PR.

@23Skidoo
Copy link
Member Author

@angerman There's --allow-boot-library-installs that allows you to ignore the blacklist.

@23Skidoo 23Skidoo closed this Dec 11, 2017
@23Skidoo 23Skidoo deleted the ghc-boot-th-noupgrade branch December 11, 2017 13:37
@23Skidoo
Copy link
Member Author

I discussed this with @hvr and we decided that it's better to keep the blacklist as small as possible. ghc-boot-th is only non-reinstallable because template-haskell depends on it, otherwise it could very well be.

@23Skidoo
Copy link
Member Author

I wouldn't mind if the blacklist was populated automatically.

dphSeqUnitId,
dphParUnitId ]

Looks like those are not built by default, e.g. ghc-pkg list on my system doesn't list them.

@angerman
Copy link
Collaborator

I think dph is effectively dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants