Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable per-component build when program coverage enabled #5004

Merged
merged 4 commits into from
Jan 7, 2018
Merged

Disable per-component build when program coverage enabled #5004

merged 4 commits into from
Jan 7, 2018

Commits on Jan 7, 2018

  1. cabal-testsuite: test cabal new-test with coverage

    @ttuegel @23Skidoo
    ttuegel authored and 23Skidoo committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    ec9ce1c View commit details
    Browse the repository at this point in the history

  2. Disable per-component build when program coverage enabled 

    Creating the test program coverage report requires the test runner to know the
build directory for the library component. If per-component builds are enabled,
this is not possible because the library is not in-scope at the same time as the
test component. The only apparent solution that does not require rethinking
per-component builds entirely is to disable it when coverage is enabled.

Resolves: haskell#4798
    @ttuegel @23Skidoo
    ttuegel authored and 23Skidoo committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    e8bf853 View commit details
    Browse the repository at this point in the history

  3. Skip the slow test on macOS for now.

    @23Skidoo
    23Skidoo committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    7d68072 View commit details
    Browse the repository at this point in the history

  4. Move GHC feature checks out of the loop.

    @23Skidoo
    23Skidoo committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    b12fd31 View commit details
    Browse the repository at this point in the history