Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'optional-target' field to plan.json #5659

Merged
merged 4 commits into from
Nov 11, 2018

Commits on Nov 11, 2018

  1. Add 'requested-by-default' field to plan.json

    Having this enables tooling to give better error messages when build output is
    missing. cabal-install can choose to include optional components in the build
    plan even though they weren't requested explicitly by the user. Currently
    tooling would have to assume missing build output after a `v2-build all` call
    means the component is currently disabled, which is just not very clean.
    DanielG authored and 23Skidoo committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    335f42b View commit details
    Browse the repository at this point in the history
  2. Rename requested-by-default to optional-target

    I prefer the convention that omitted boolean JSON fields default
    to being `false`. Also, "target" makes it a bit more evident
    this is about CLI targets.
    hvr authored and 23Skidoo committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    0ea892c View commit details
    Browse the repository at this point in the history
  3. Tweak naming.

    23Skidoo committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    a385034 View commit details
    Browse the repository at this point in the history
  4. Formatting.

    23Skidoo committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    b20f3f5 View commit details
    Browse the repository at this point in the history