Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dependency on private library #5848

Merged
merged 5 commits into from Jun 25, 2019
Merged

Prevent dependency on private library #5848

merged 5 commits into from Jun 25, 2019

Commits on May 7, 2019

  1. Prevent dependency on private library

    @fgaz
    fgaz committed May 7, 2019
    Copy the full SHA
    cf27290 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2019

  1. Always mark main (unnamed) libraries as public 

    ghc-pkg<8.8 cannot read the visibility field, so all libraries were reported
as private, even the main (unnamed) one. This commit forces the
visibility of main libraries to be "public".

This commit can be reverted once we stop supporting GHC<8.8, at the
condition that we keep marking main libraries as public when registering
them.
    @fgaz
    fgaz committed Jun 8, 2019
    Copy the full SHA
    991eaba View commit details
    Browse the repository at this point in the history

  2. --accept some tests 

    Related to the previous two commits (preventing dependency on private
libraries and marking main libraries as public)
    @fgaz
    fgaz committed Jun 8, 2019
    Copy the full SHA
    c7b927c View commit details
    Browse the repository at this point in the history

  3. Add a negative test for multilibs

    @fgaz
    fgaz committed Jun 8, 2019
    Copy the full SHA
    f14d4a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Add a flag to allow depending on private libraries 

    This is intended to be used by tools like cabal-install so they can add
multilibs-compatibility even to older ghcs
    @fgaz
    fgaz committed Jun 17, 2019
    Copy the full SHA
    3e31042 View commit details
    Browse the repository at this point in the history