-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ghc 9.0 to ci #7318
Add ghc 9.0 to ci #7318
Conversation
I guess it has to be in master... |
validate-9_0_1: | ||
name: validate.sh ghc-9.0.1 | ||
runs-on: ubuntu-18.04 | ||
needs: validate-8_8_3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.0.1 job will start after 8.8.3 passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, thanks. I assumed it would show as "waiting for dependency" or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Waiting for status to be reported jobs are there because they are required to pass before non-admins can merge. I.e. they (EDIT: or rather "their existences") come from repository settings, not in-repo CI config.
At least in
So I doubt the job will succeed. |
it did fail, but even before than the solving phase: there's no 9.0 container |
Hmm. I build the containers, but looks like I forgot to push them. They'll be up in an hour or so (many bytes to upload). |
Blocked on haskell-hvr/cryptohash-sha256#12 (or I could leave there the allow-newer if the tests pass) |
I pushed the containers for 9.0 |
Blocked on https://hub.darcs.net/shelarcy/regex-compat-tdfa/issue/2 too |
@fgaz, I'd drop EDIT: screw that. I guess we need unicode support for where |
7485fb5
to
a9f2fcf
Compare
...I just copied the only function we use and fixed it. @phadej what would you replace regexes with? |
Good question. I'm not sure what |
This comment has been minimized.
This comment has been minimized.
Upstream looks unmaintained, and we only use a single function anyway. The package did not build with ghc 9, so we include a fixed version of that function.
Let's see if this works...
#7315