Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghc 9.0 to ci #7318

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Add ghc 9.0 to ci #7318

merged 5 commits into from
Mar 18, 2021

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Mar 6, 2021

Let's see if this works...

#7315

@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2021

I guess it has to be in master...

validate-9_0_1:
name: validate.sh ghc-9.0.1
runs-on: ubuntu-18.04
needs: validate-8_8_3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.0.1 job will start after 8.8.3 passes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks. I assumed it would show as "waiting for dependency" or something

Copy link
Collaborator

@phadej phadej Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Waiting for status to be reported jobs are there because they are required to pass before non-admins can merge. I.e. they (EDIT: or rather "their existences") come from repository settings, not in-repo CI config.

@phadej
Copy link
Collaborator

phadej commented Mar 6, 2021

At least in master:

% make cabal-install-dev
% cabal build -w ghc-9.0.1 --dry all
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: Cabal-3.5.0.0 (user goal)
[__1] trying: base-4.15.0.0/installed-4.15.0.0 (dependency of Cabal)
[__2] trying: Cabal-described-3.5.0.0 (user goal)
[__3] next goal: rere (dependency of Cabal-described)
[__3] rejecting: rere-0.1 (conflict: base==4.15.0.0/installed-4.15.0.0, rere
=> base>=4.3.0.0 && <4.15)
[__3] fail (backjumping, conflict set: Cabal-described, base, rere)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: base, Cabal, Cabal-described, rere
Try running with --minimize-conflict-set to improve the error message.

So I doubt the job will succeed.

@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2021

it did fail, but even before than the solving phase: there's no 9.0 container

@phadej
Copy link
Collaborator

phadej commented Mar 6, 2021

Hmm. I build the containers, but looks like I forgot to push them. They'll be up in an hour or so (many bytes to upload).

@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2021

Blocked on haskell-hvr/cryptohash-sha256#12 (or I could leave there the allow-newer if the tests pass)

@phadej
Copy link
Collaborator

phadej commented Mar 6, 2021

I pushed the containers for 9.0

@fgaz
Copy link
Member Author

fgaz commented Mar 6, 2021

@phadej
Copy link
Collaborator

phadej commented Mar 6, 2021

@fgaz, I'd drop regex-compat-tdfa from cabal-testsuite in favour of regex-posix or regex-tdfa (both of which work on windows nowadays). EDIT: and are maintained.

EDIT: screw that. I guess we need unicode support for where regex-compat-tdfa is used. But maybe using regexes there (in OutputNormalizer) is something we need to rethink finally. That module is a nightmare.

@fgaz fgaz force-pushed the ghc-9.0-ci branch 2 times, most recently from 7485fb5 to a9f2fcf Compare March 8, 2021 15:03
@fgaz
Copy link
Member Author

fgaz commented Mar 8, 2021

...I just copied the only function we use and fixed it.

@phadej what would you replace regexes with?

@phadej
Copy link
Collaborator

phadej commented Mar 8, 2021

Good question. I'm not sure what regex-compat-tdfa does, looks like that not much, so I'd just use regex-tdfa https://hackage.haskell.org/package/regex-compat-tdfa-0.95.1.4/docs/src/Text-Regex.html

@fgaz

This comment has been minimized.

fgaz added 5 commits March 9, 2021 17:57
Upstream looks unmaintained, and we only use a single function anyway.
The package did not build with ghc 9, so we include a fixed version of
that function.
@fgaz fgaz merged commit a234f67 into haskell:master Mar 18, 2021
@fgaz fgaz deleted the ghc-9.0-ci branch March 18, 2021 23:53
fgaz added a commit that referenced this pull request Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants