-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #7765: Add -c alias for --constraint cli argument #7766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update doc/cabal-project.rst
too
How? It is documenting the
But this PR doesn't change |
here is where I was thinking. as far as I understand, cabal-project.rst documents both cabal.project and cli options. For example here are a couple with a shorthand: https://cabal.readthedocs.io/en/3.6/cabal-project.html#cfg-flag---flags https://cabal.readthedocs.io/en/3.6/cabal-project.html#cfg-flag---jobs I might be wrong though. I'll retract the review, so you can merge if that's the case |
d06d3ea
to
ecec1f7
Compare
ping |
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!