Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #7765: Add -c alias for --constraint cli argument #7766

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Oct 21, 2021


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgaz
fgaz previously requested changes Oct 22, 2021
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update doc/cabal-project.rst too

@phadej
Copy link
Collaborator Author

phadej commented Oct 22, 2021

Please update doc/cabal-project.rst too

How? It is documenting the cabal.project file. There you still have to write constraints: ....

setup-commands has mention of

.. option:: -f flagname or -f -flagname

    Force the specified flag to ``true`` or ``false`` (if preceded with
    a ``-``). Later specifications for the same flags will override
    earlier, i.e., specifying ``-fdebug -f-debug`` is equivalent to
    ``-f-debug``

.. option:: --flags=flagspecs

    Same as ``-f``, but allows specifying multiple flag assignments at

But this PR doesn't change Setup.hs flags, and I don't know where the cabal-install CLI interface is documented?

@fgaz
Copy link
Member

fgaz commented Oct 22, 2021

here is where I was thinking. as far as I understand, cabal-project.rst documents both cabal.project and cli options. For example here are a couple with a shorthand: https://cabal.readthedocs.io/en/3.6/cabal-project.html#cfg-flag---flags https://cabal.readthedocs.io/en/3.6/cabal-project.html#cfg-flag---jobs

I might be wrong though. I'll retract the review, so you can merge if that's the case

@phadej
Copy link
Collaborator Author

phadej commented Oct 22, 2021

Screenshot from 2021-10-23 00-14-04

@Mikolaj Mikolaj mentioned this pull request Oct 25, 2021
6 tasks
@phadej
Copy link
Collaborator Author

phadej commented Oct 28, 2021

ping

@fendor fendor merged commit 6956314 into haskell:master Oct 28, 2021
@phadej phadej deleted the issue-7765-c-alias branch October 28, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants