Improve tool finding failure #8066
Conversation
| @@ -339,7 +339,7 @@ configureProgram verbosity prog progdb = do | |||
| if absolute | |||
| then return (Just (UserSpecified path, [])) | |||
| else findProgramOnSearchPath verbosity (progSearchPath progdb) path | |||
| >>= maybe (die' verbosity notFound) | |||
| >>= maybe (dieAll verbosity notFound (Just path) 77) | |||
There was a problem hiding this comment.
path goes to stdout and we set exit code to 77... this can serve as a hint for calling tools, which may parse stdout and do stuff with it
There was a problem hiding this comment.
If one doesn't like stdout (because bad scripts don't check exit code before eating stdout): another approach might be to have a better format for the stderr message, that can be parsed.
There was a problem hiding this comment.
I think it might be reasonable to guard this behavior through a cli switch. It might break existing scripts.
There was a problem hiding this comment.
True, this is a breaking change, otherwise. Additionally, I don't think we can in general rely on that nothing else has written to stdout, since e.g. haddock and hpc just pollute everything.
There was a problem hiding this comment.
I don't think we can in general rely on that nothing else has written to stdout, since e.g. haddock and hpc just pollute everything
I'm not sure I follow. What do you mean?
There was a problem hiding this comment.
Just a general concern that stdout is often polluted by other external tools, such as haddock and hpc. In this specific situation, it should be safe for external tools, such as hls, to try to read the last line of stdout to get the path.
There was a problem hiding this comment.
I don't think there will be any stdout when cabal exec ghc fails to find ghc.
| =<< pure . wrapTextVerbosity verbosity | ||
| =<< pure . addErrorPrefix | ||
| =<< prefixWithProgName stderrMsg | ||
| forM_ stdoutMsg $ hPutStrLn stdout |
There was a problem hiding this comment.
| forM_ stdoutMsg $ hPutStrLn stdout | |
| for_ stdoutMsg $ hPutStrLn stdout |
Cabal re-exports for_ with its prelude
| @@ -214,6 +215,7 @@ import Data.Typeable | |||
| ( cast ) | |||
| import qualified Data.ByteString.Lazy as BS | |||
|
|
|||
| import Control.Monad (forM_) | |||
There was a problem hiding this comment.
| import Control.Monad (forM_) |
Not needed with the suggestion for_
mergify
bot
added
the
merge delay passed
ulysses4ever
removed
the
merge delay passed
|
@hasufell I'll mark this PR as draft, feel free to rebase & fix the CI when you have some free time (I know it's hard to come by these days :) |
Related: