Export CompatFilePath and CompatLicenseFile

[andreabedini]

These two types need to be exported for users to be able to define their own FieldGrammar.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[ulysses4ever]

LGTM thanks!

[Kleidukos]

LGTM

[ulysses4ever]

Just curious: any reason not to use the merge bot?

[andreabedini]

@ulysses4ever oh damn it, I forgot. Is there a way to disable the green button? Or perhaps take away my merge permission, I’m just an occasional contributor after all.

[ulysses4ever]

@andreabedini right: it's super easy to forget, I agree. As to how to improve on this, I'm not totally sure, but some directions that can be investigated:

• protected branches can have restrictions on who can merge this;

• permissions for most people can be rollbacked to "Triage", at most.

The former seems to be the proper solution. Unfortunately, it requires GitHub Team or GitHub Enterprise Cloud organization account. I'm guessing, haskell doesn't have it?

What are downsides of the latter? I think, the only sensitive change is that people won't be able to push their dev branches to haskell/cabal and will have to use their forks of the cabal repo. I have to admit, this may be a bit annoying (it's just more expedite and straightforward to be able to work with one remote instead of two). But this is certainly not the end of the world.

@Mikolaj do you have any thoughts on this?

Meanwhile, we just had another direct merge. I'd guess the reason is the same: the person wasn't aware about the bot but had Write permissions.

[andreabedini]

I cannot speak for other developers but I would be ok with Triage level.

[Mikolaj]

@andreabedini: you've been awarded the coveted Triage role. Thank you for your exemplary Write service.

We are advised by Haskell org admins to prefer the Triage role, so slowly migrating that way makes sense. I don't see in Settings the possibility of restricting the Merge button, so I guess we can't.

[ulysses4ever]

@Mikolaj

We are advised by Haskell org admins to prefer the Triage role, so slowly migrating that way makes sense.

any reason in the "slowly" bit in particular? Wouldn't it be better to do a bulk rollback of Write permissions and be done with it? The interface at github.com/<owner>/<repo>/settings/access seems pretty handy for that sort of operations: you can filter by the write role, "Select All" and change the role to triage.

[Mikolaj]

I'd be miffed if anybody took away my Write permission. ;)