Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check: add PackageInfo warning #9525

Merged
merged 1 commit into from
Dec 21, 2023
Merged

check: add PackageInfo warning #9525

merged 1 commit into from
Dec 21, 2023

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Dec 15, 2023 •
edited

“Backport” of #9481, should be the last step (and close) #9331.

Include the following checklist in your PR:

QA instructions

  • create a package
  • use the PackageInfo_* autogenerated module
  • cabal check will warn and suggest you to update to cabal 3.12.

Things to double-check:

  • the logic behind the check (it fires every time it finds a PackageInfo_* module, regardless of cabal-version)
  • the warning message 
    Warning: To use the autogenerated module PackageInfo_* you need to specify `cabal-version: 3.12` or higher. This is not possible in `cabal 3.10`. To use this feature and be able to upload your package to Hackage, download `cabal 3.12`!
    Note that 3.12 has not been released yet.
  • does this actually close PackageInfo functionality is not guarded behind cabal-version. #9331?

@ffaf1 ffaf1 changed the title check: guard PackageInfo behind cabal-version ≥ 3.12 check: add PackageInfo warning Dec 15, 2023
@ffaf1 ffaf1 linked an issue Dec 15, 2023 that may be closed by this pull request
PackageInfo functionality is not guarded behind cabal-version. #9331
Closed
@ffaf1 ffaf1 force-pushed the autogen-check-3.10 branch 2 times, most recently from 2a5bacf to b6f775d Compare December 15, 2023 19:06
@ffaf1 ffaf1 marked this pull request as ready for review December 15, 2023 19:42
@Mikolaj Mikolaj mentioned this pull request Dec 16, 2023
Closed
Mikolaj
Mikolaj approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on.

@ffaf1 ffaf1 added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review cabal-install: cmd/check labels Dec 16, 2023
@Mikolaj Mikolaj added merge me Tell Mergify Bot to merge and removed squash+merge me Tell Mergify Bot to squash-merge merge me Tell Mergify Bot to merge labels Dec 21, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Dec 21, 2023

@mergify squash

@Mikolaj
check: add PackageInfo warning (haskell#9525)
90249c6 
Add test for haskell#9331

Guard Paths_* behind `cabal-version: 3.12` or higher, “fail” and
“succeed” tests.

* check: guard PackageInfo behind cabal-version ≥ 3.12

Note we do not actually check for ≥ 3.12, since it is not possible
to introduce constructors in point release.
Instead the check always fires with PackageInfo_* is present, and
suggests an upgrade path.

* Fix testsuite

* Add changelog
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023

squash

✅ Pull request squashed successfully

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Dec 21, 2023
@Mikolaj Mikolaj self-assigned this Dec 21, 2023
@Mikolaj Mikolaj added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 21, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Dec 21, 2023

That's not a real backport, but an original PR, which is probably why mergify ignores us. Given that, I'm going to merge via the big red button.

@Mikolaj
Copy link
Member

Mikolaj commented Dec 21, 2023

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023

rebase

✅ Nothing to do for rebase action

@Mikolaj Mikolaj merged commit 5fefcf5 into haskell:3.10 Dec 21, 2023
39 checks passed
@ffaf1 ffaf1 deleted the autogen-check-3.10 branch December 22, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees

@Mikolaj Mikolaj

Labels
backport merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PackageInfo functionality is not guarded behind cabal-version.
2 participants
@ffaf1 @Mikolaj