Merge two Globbing Modules and Fix #5349

[alt-romes]

Merge the two Globbing modules in cabal and cabal-install

We use the datatype representation from the globbing in cabal-install,
but preserve a standalone parser for globs present in cabal files, whose
specification is constrained by the cabal specification. The
implementations are merged taking the best parts of each.

and

Make sure sdist is robust to accidentally-listed directories

The refactor of the globbing modules re-uncovered this issue, and
required a prompt fix for the refactor not to break some things.

Fixes #5349

Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

• Patches conform to the coding conventions.

[Kleidukos]

Ah, interesting failure: https://github.com/haskell/cabal/actions/runs/7745458515/job/21121495479?pr=9673#step:19:52

[ffaf1]

Also this is Template A.

[alt-romes]

@andreabedini light ping. Sam has improved the MR and addressed the rest of the review.
Shall we merge it?

[fgaz]

This comment still has to be addressed

Also this is Template A.

[alt-romes]

This comment still has to be addressed

Also this is Template A.

I replied here:

I don't think I have changed any behaviour, except for maybe the directory-not-exists error being reported instead of file-does-not-match, in some situations where the directory does not exist (in others, we would already report this correctly).
I've updated the tests accordingly.

[alt-romes]

@fgaz what specifically do you think we're missing?

[fgaz]

Oh, sorry, I missed that comment.

If the Cabal API changed pheraps add a changelog entry and/or @since annotations

Outdated

[andreabedini]

I'm ok but please do add a changelog entry and @SInCE annotations and consider explicitly listing the intended exports of Distribution.Simple.Glob.

[sheaf]

The only changes in the user-facing API are:

• addition of the GlobMatchesDirectory constructor of GlobResult,
• new function globMatches.

I made a separate Distribution.Simple.Glob.Internal module for the internal implementation details, in order to preserve the user-facing API of Distribution.Simple.Glob. Note that Distribution.Simple.Glob.Internal is nonetheless an exposed module of the Cabal library, because cabal-install file monitoring needs access to the internals.

[sheaf]

I'm ok but please do add a changelog entry and @SInCE annotations and consider explicitly listing the intended exports of Distribution.Simple.Glob.

Done.