Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parts of SetupWrapper #9735

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Refactor parts of SetupWrapper #9735

wants to merge 2 commits into from

Conversation

andreabedini
Copy link
Collaborator

This patch lifts many functions defined in a where clause to top-level functions. This reduces the level of scope nestings and improves the readability of the codebase.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ulysses4ever
Copy link
Collaborator

Should it be considered a Draft until CI is green?

@andreabedini
Copy link
Collaborator Author

Should it be considered a Draft until CI is green?

Yes 👍 😊

@andreabedini andreabedini marked this pull request as draft February 28, 2024 03:10
@andreabedini
Refactor parts of SetupWrapper
8187919 
This patch lifts many functions defined in a where clause to top-level
functions. This reduces the level of scope nestings and improves the
readability of the codebase.
@andreabedini andreabedini mentioned this pull request May 10, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheaf sheaf Awaiting requested review from sheaf

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreabedini @ulysses4ever