New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade NoLibraryFound from an error to a warning #9926
base: master
Are you sure you want to change the base?
Conversation
7980205
to
92ab485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm not familiar with these code paths.
Re tests, the default seems to be cabal-testsuite.
92ab485
to
94cee1f
Compare
I've added a test case of a package that is just a test suite. In fact this is one of the options offered by the |
94cee1f
to
5fb3e36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't see a need to emit an error here so this seems like an improvement.
5fb3e36
to
6d9ea26
Compare
@TeofilC: could you kindly set a merge label, confirming you finished tweaking the PR, as per https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions? Thank you. |
Sounds good. Thanks! |
This makes Setup copy/install succeed if there's nothing to do because the package doesn't contain a library or executable. This allows downstream users of Cabal to avoid having to add workarounds for this edge case. Resolves #6750
6d9ea26
to
c12f295
Compare
This makes Setup copy/install succeed if there's
nothing to do because the package doesn't contain
a library or executable.
This allows downstream users of Cabal to avoid having to add workarounds for this edge case.
Resolves #6750
Let me know what you think. If this sounds OK, I'll add a test case, which test suite would be best?