Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git tags for v0.6.3.1 #737

Closed
sjakobi opened this issue Jul 15, 2020 · 9 comments
Closed

Git tags for v0.6.3.1 #737

sjakobi opened this issue Jul 15, 2020 · 9 comments

Comments

@sjakobi
Copy link
Member

sjakobi commented Jul 15, 2020

There's a bit of confusion about the git tag that corresponds to the v0.6.3.1 Hackage upload.

  • The v0.6.3.1 and v0.6.3.1a tags still have the wrong package version number in the cabal file.

  • v0.6.3.1b has the correct package version number, but doesn't specify any default-language fields:

    $ cabal check
    Warning: The following warnings are likely to affect your build negatively:
    Warning: Packages using 'cabal-version: >= 1.10' must specify the
    'default-language' field for each component (e.g. Haskell98 or Haskell2010).
    If a component uses different languages in different modules then list the
    other ones in the 'other-languages' field.
    Warning: These warnings may cause trouble when distributing the package:
    Warning: 'ghc-options: -O2' is rarely needed. Check that it is giving a real
    benefit and not just imposing longer compile times on your users.
    Warning: Hackage would reject this package.
    
  • 97fe43c seems to correspond to the uploaded version, but hasn't been tagged yet.

I'm not sure how to best resolve this. How about we tag 97fe43c as e.g. v0.6.3.1-release to clarify that this is the one?

CC @fumieval

@treeowl
Copy link
Contributor

treeowl commented Jul 15, 2020

Yeah, makes sense. I suck at tagging. Please go ahead and do that.

@sjakobi
Copy link
Member Author

sjakobi commented Jul 15, 2020

No worries @treeowl!

Let's try to be sure that we solve this properly now though.

How about we tag 97fe43c as e.g. v0.6.3.1-release to clarify that this is the one?

@fumieval What do you think about this idea?

@fumieval
Copy link
Contributor

Sounds good to me

@sjakobi
Copy link
Member Author

sjakobi commented Jul 16, 2020

I've made a proper GitHub release to give this tag a bit more authority. ;)

https://github.com/haskell/containers/releases/tag/v0.6.3.1-release

@sjakobi
Copy link
Member Author

sjakobi commented Jul 16, 2020

I wonder whether we should delete the other tags?!

@treeowl
Copy link
Contributor

treeowl commented Jul 16, 2020

Oh, is that a thing we can even do?

@treeowl
Copy link
Contributor

treeowl commented Jul 16, 2020

Looks like yes! Done. Wish I'd known that......

@treeowl treeowl closed this as completed Jul 16, 2020
@sjakobi
Copy link
Member Author

sjakobi commented Jul 16, 2020

Cool! :)

Note that AFAIK it's a bit of a no-no to reassign published tags. We've avoided that here though.

ghc-mirror-bot pushed a commit to ghc/ghc that referenced this issue Jul 16, 2020
See haskell/containers#737
in case of doubt about the correct release tag.
ghc-mirror-bot pushed a commit to ghc/ghc that referenced this issue Jul 16, 2020
See haskell/containers#737
in case of doubt about the correct release tag.
@sjakobi
Copy link
Member Author

sjakobi commented Jul 19, 2020

BTW, I used this SO answer to delete the removed tags from my local repo: https://stackoverflow.com/a/5373319/1013393

ghc-mirror-bot pushed a commit to ghc/ghc that referenced this issue Sep 25, 2020
See haskell/containers#737
in case of doubt about the correct release tag.
ghc-mirror-bot pushed a commit to ghc/ghc that referenced this issue Oct 6, 2020
See haskell/containers#737
in case of doubt about the correct release tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants