Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false negatives in IntMap.isProperSubmapOfBy #1008

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix false negatives in IntMap.isProperSubmapOfBy #1008

merged 1 commit into from
Jun 4, 2024

Conversation

meooow25
Copy link
Contributor

Fixes #1007

treeowl
treeowl reviewed Jun 4, 2024
View reviewed changes
containers-tests/tests/intset-properties.hs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a property test for sets and maps that catches this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property test is how konsumlamm caught this (#1007).

But it's random and such cases are apparently unlikely, so it didn't show up when the test was added (in #995).

@treeowl
Copy link
Contributor

treeowl commented Jun 4, 2024

Missed that.

@treeowl treeowl merged commit b2a54c8 into haskell:master Jun 4, 2024
10 checks passed
@treeowl
Copy link
Contributor

treeowl commented Jun 4, 2024

Thanks!

@meooow25 meooow25 deleted the intmap-ispropersubmapof branch June 4, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeowl treeowl treeowl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntMap isProperSubmapOfBy test failure
2 participants
@meooow25 @treeowl