Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Werror in CI #740

Closed
wants to merge 1 commit into from
Closed

Use -Werror in CI #740

wants to merge 1 commit into from

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Jul 15, 2020

Supersedes #645.

@sjakobi sjakobi changed the title Use -Werror in CIs Use -Werror in CI Jul 15, 2020
@sjakobi
Copy link
Member Author

sjakobi commented Jul 15, 2020

Actually we probably don't need this. This should be good enough:

containers/containers-tests/containers-tests.cabal

Lines 95 to 96 in 1338d9b

if impl(ghc >= 8.6)
ghc-options: -Werror

@sjakobi sjakobi closed this Jul 15, 2020
@sjakobi sjakobi deleted the ci-werror branch July 15, 2020 23:11
@sjakobi sjakobi mentioned this pull request Jul 15, 2020
Closed
@treeowl
Copy link
Contributor

treeowl commented Jul 16, 2020

Ooh, sneaky. I guess the Hackage -Werror rules only apply to things going on Hackage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjakobi @treeowl