Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed test and benchmark instructions #943

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

meooow25
Copy link
Contributor

No description provided.

Copy link
Contributor

@treeowl treeowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I've requested one little change.

CONTRIBUTING.md Outdated
cabal bench containers-tests
```

To run a particular test or benchmark suite, name the target from `containers-tests.cabal`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To run a particular test or benchmark suite, name the target from `containers-tests.cabal`:
To run a particular test or benchmark suite, name the target from `containers-tests/containers-tests.cabal`:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@treeowl treeowl merged commit 7b27da8 into haskell:master Mar 18, 2023
@treeowl
Copy link
Contributor

treeowl commented Mar 18, 2023

Thanks!

@meooow25 meooow25 deleted the contrib branch March 19, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants