New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get "xxx" in the report for long-running computations #65
Comments
I have done a little investigating. This bug happens when the
As the browser loads the page, a JavaScript error happens when it tries to run Where do these
I am seeing "null" values end up in this field (among others):
Somehow criterion is calculating this This is as far as I have come with my investigation. |
More evidence. I've spotted the
|
I currently am unable to dig further into this bug. Hopefully the info above can point someone who is more familiar with the criterion codebase in the right direction. |
@RyanGlScott, we had a problem with this as well, but now I can't remember what it was. Do you? |
I think the issue might have been that the Therefore, I'm tempted to claim this bug as fixed. |
I'm also getting this with criterion-1.1.1.0. |
Sadly, 1.1.1.0 doesn't include the linked commit. It sounds like it is time to do a 1.1.1.1 release for bugfixes. @RyanGlScott and @bos - any opinions about where to cut that? There's currently a "1.2" branch corresponding to the statistics 0.14 release. The Additions like I'm not completely sure if that should be 1.1.X or 1.2, however. We also changed the default report format to json, so this is a breaking change that should require a major version bump. If we do the major version bump and push out 1.2 now, then the statistics-0.14 version can slide down to 1.3. |
Could you, @tswilkinson and @bitc, see if you can reproduce the error on master? |
Ack, I spoke too soon. I can still reproduce this error with |
I did some digging into this recently, and I think I've narrowed the issue down to a function in (coeffs,r2) <- liftIO $
bootstrapRegress gen resamples confInterval olsRegress ps r I've managed to get
Notice the @Shimuuar, do have any idea why |
Here's what I believe to be a more deterministic way of reproducing the bug, using
This time, the |
I'll look into it. |
My guess is resample sometimes gives values where every point have same |
I was right about this one. I think problem appear in long running computations because they collect less samples and resample where all values are same is more likely. |
On Thu, 17 Nov 2016, Aleksey Khudyakov wrote:
That matches my experience. |
Thanks for looking into this, @Shimuuar! (For reference, the |
I think proper solution will require changes to linear regression API and consequently bootstrapRegress. I think simply returning NaN is bad idea as this issue shown. Lack of unique solution should be reported in more obvious way like returning Nothing. |
On Thu, 17 Nov 2016, Aleksey Khudyakov wrote:
An alternative way would be to go the way of LAPACK or pseudo inverses, |
If a computation runs quite long, say, longer than 0.5s, then I get a result like:
in the HTML report and then all following regression results are "xxx", too. This also implies that the overview diagram is not generated.
The text was updated successfully, but these errors were encountered: