Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign.Ptr instances. #10

Merged
merged 1 commit into from Oct 13, 2015

Conversation

@mboes
Copy link
Contributor

commented Oct 4, 2015

deepseq currently defines instances for Foreign.C.Types, but not for
Ptr and FunPtr, both exported from Foreign.Ptr. This PR remedies
the situation.

I believe that the PVP does not require a major version bump here,
since the extra instances are not orphan instances. But feel free to
modify the "Since:" Haddock annotation accordingly.

@hvr

This comment has been minimized.

Copy link
Member

commented Oct 4, 2015

Yes, we only require a minor version bump according to the revised PVP.

Would you mind adding a changelog.md entry mentioning those two instances?

PS: the next version will be 1.4.2, not 1.4.3 (deepseq follows the early-version-bumping scheme)

@glguy glguy merged commit b88c2ed into haskell:master Oct 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
glguy added a commit that referenced this pull request Oct 13, 2015
glguy added a commit that referenced this pull request Oct 13, 2015

@hvr hvr added this to the 1.4.2.0 milestone Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.