Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFData and NFData1 instances for Compose #30

Merged
merged 2 commits into from Apr 8, 2017

Conversation

@pepeiborra
Copy link
Contributor

commented Feb 27, 2017

Please review. Not sure whether the NFData instance should build on the NFData1 instance or not.

@RyanGlScott

This comment has been minimized.

Copy link
Member

commented Apr 6, 2017

Sorry for taking so long to get around to this!

I agree that using NFData1 is the way to go here. But since you're in town—there were also similar datatypes in Data.Functor.Sum and Data.Functor.Product that were added to base at the same time that Compose was. Can you add NFData(1) instances for them as well to complete the trio?

Thanks!

@pepeiborra

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2017

No problem, I have updated the branch with the additional instances.

@RyanGlScott

This comment has been minimized.

Copy link
Member

commented Apr 8, 2017

Looks good to me.

@hvr, should we merge this now, or wait until after the imminent release of the next deepseq that will be bundled with GHC 8.2?

@hvr

This comment has been minimized.

Copy link
Member

commented Apr 8, 2017

@RyanGlScott if we're confident that these instances are correct, I see no reason to delay (there's a few other things I want to cleanup before I feel good enough about tagging 1.4.3) ... while GHC 8.2.1 RC1 won't have them, it's a given we're gonna have a GHC 8.2.1 RC2... and that's gonna have the final deepseq-1.4.3

@RyanGlScott RyanGlScott merged commit 7ef5f11 into haskell:master Apr 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
RyanGlScott added a commit that referenced this pull request Apr 8, 2017
Update CHANGELOG for #30
Plus some minor code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.