add more haskell build artifacts to .gitignore #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Jun 24, 2019
There was a problem hiding this comment.
@hvr is pickier about .gitignore files than I am, so I'll let him make the final call here. Otherwise, LGTM.
hvr
reviewed
Jun 26, 2019
| ghc.mk | ||
| *.hi | ||
| *.o | ||
| .ghc.environment* |
There was a problem hiding this comment.
Fwiw, if we're adding more stuff, I'm also missing /cabal.project.local and possibly /cabal.project.freeze
|
In general, I tend to add .gitignores as I notice them (and I tend to be rather minimal about them); and yes, there is also the convention to add certain ubiqutous patterns to your |
|
I think in practise this doesn't cause any issues. I use a global .gitignore now. Anyone feel free to re-open if they think this is a good addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to see the .gitignore so bare. I guess most contributors just have these in their global .gitignores? I think having these would be beneficial, and make it easier to stop build artifacts from muddying the tree.