Fix incorrect comment about removeDirectoryRecursive and symlinks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this behavior the same on Windows as well as Unix? |
|
TL;DR: Yes. Behavior depends on semantics of 'removeFile' that on Windows is 'Win32.deleteFile' and that is a simple wrapper around DeleteFile system call. MSDN says: Symbolic link behavior - If the path points to a symbolic link, the symbolic link is deleted, not the target. To delete a target, you must call CreateFile and specify FILE_FLAG_DELETE_ON_CLOSE. http://msdn.microsoft.com/en-us/library/windows/desktop/aa363915%28v=vs.85%29.aspx |
hvr
added a commit
that referenced
this pull request
Jan 16, 2015
Fix incorrect comment about removeDirectoryRecursive and symlinks
bgamari
pushed a commit
to bgamari/directory
that referenced
this pull request
Jul 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeDirectoryRecursive removes symlinks inside the directory before it has a chance to follow them.
Exception is the initial path, there symlink is followed. Arguably it should not be the case.