Move the stack args to just before they are needed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases layer cacheability so that new stack versions will not invalide the ghc / cabal install layer.
|
Thanks again. This is a solid improvement, and your suggestion to optimize the apt bits further is also legit. I like the change more for a different reason: it makes the Dockerfile clearer about which packages came from which repositories. Anything NOT from haskell.org repos could be put in the first install. Happy to take another look if you do it, otherwise I'm good with this as-is if not. 🍻 |
|
Sounds good :) I've made the additional change. I probably wouldn't worry about doing a release for this change btw. Just wait until something gets bumped and then do a release. |
psftw
reviewed
May 12, 2021
8.10/buster/Dockerfile
Outdated
| @@ -3,7 +3,20 @@ FROM debian:buster | |||
| ENV LANG C.UTF-8 | |||
|
|
|||
| RUN apt-get update && \ | |||
| apt-get install -y --no-install-recommends gnupg ca-certificates dirmngr && \ | |||
| apt-get install -y --no-install-recommends \ | |||
| gnupg \ | |||
There was a problem hiding this comment.
nitpick -- indent and sort by name to be consistent 🤓
AlistairB
force-pushed
the
move-stack-args
branch
from
5a464fd
to
eba4575
Compare
|
Good call! Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases layer cacheability so that new stack versions will not invalidate the ghc / cabal install layer. As noted by @yosifkit docker-library/official-images#10140 (comment)
You could maximise layer caching further by moving the ghc / stack required packages ie.
g++to the initialapt-get install, which would mean new cabal versions would not invalidate these packages from being installed (or from the user's perspective, the invalidated layers they need to redownload are smaller). My inclination would be to do this change as well, or perhaps the current logical grouping has value? Any thoughts @psftw ?EDIT: Hmm investigating the failure.. ok seems to have been a flaky gpg issue, or a caching issue. Rerunning fixed it.