Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC-1629 #123

Merged
merged 6 commits into from
Jun 12, 2022
Merged

GHC-1629 #123

merged 6 commits into from
Jun 12, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jun 12, 2022

Please be harsh with your review, i want the next PR to be better! :)

message-index/messages/GHC-1629/example1/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-1629/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-1629/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@david-christiansen david-christiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's basically fine - I'm not good at harshness, though :)

message-index/messages/GHC-1629/index.md Outdated Show resolved Hide resolved
message-index/messages/GHC-1629/index.md Outdated Show resolved Hide resolved
fisx and others added 3 commits June 12, 2022 16:21
Co-authored-by: PrettyPrincessKitty FS <thecommunistduck@hotmail.co.uk>
Co-authored-by: PrettyPrincessKitty FS <thecommunistduck@hotmail.co.uk>
Co-authored-by: David Thrane Christiansen <david@davidchristiansen.dk>
@fisx
Copy link
Contributor Author

fisx commented Jun 12, 2022

thanks for the feedback! :)

@david-christiansen
Copy link
Collaborator

Doesn't GHC say GHC-01629?

@fisx fisx merged commit 8ed67a6 into haskell:main Jun 12, 2022
@fisx fisx deleted the GHC-1629 branch June 12, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants