Show examples inline #145
Merged
Show examples inline #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really nice! Much better than what I had made. I'll test it out tomorrow. Do examples still have their own URLs? If so, it might be nice to either make those accessible or to eliminate them and add permalinkable anchors here. What do you think? |
|
My personal preference would be to remove them and add the anchors. |
|
I would tend to agree. I think that pages that few people look at are likely to bitrot. But we can always do that after a merge of this one. |
david-christiansen
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way Examples are shown, from its own page into a collapsible panel in the message itself. And even better, this is done without any JavaScript, only pure HTML!