Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diffing of before/after examples #180

Closed
wants to merge 1 commit into from
Closed

Add diffing of before/after examples #180

wants to merge 1 commit into from

Conversation

isomorpheme
Copy link
Contributor

No description provided.

@isomorpheme isomorpheme changed the title wip! Add diffing of before/after examples Add diffing of before/after examples Jun 13, 2022
@elland
Copy link
Contributor

elland commented Jun 20, 2022

Hi @isomorpheme are you still working on this, or should someone pick it up? :)

@isomorpheme
Copy link
Contributor Author

@elland Yes! At this point I'm trying to figure out how to make syntax highlighting work with the table-based diff rendering - it may be necessary to do it at build time instead of client side, depending on how flexible highlight.js can be. Help is always welcome of course.

I'm also not sure how best to approach the CSS part of this, so I appreciate help from anyone who's good at that. :)

@elland
Copy link
Contributor

elland commented Jun 20, 2022

@isomorpheme I think moving that to server side would certainly improve things in general, since pandoc already provides that facility. CSS is way out of my wheelhouse but I can check that too, after the fact.

@david-christiansen
Copy link
Collaborator

The message index has moved to https://github.com/haskellfoundation/error-message-index - would you mind re-opening this PR there? There doesn't seem to be a way to automatically migrate PRs the way there is for issues. We can then link back here for discussion visibility.

Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants