Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GHC-24180 #186

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Document GHC-24180 #186

merged 2 commits into from
Jun 14, 2022

Conversation

david-christiansen
Copy link
Collaborator

No description provided.

@PPKFS
Copy link
Contributor

PPKFS commented Jun 13, 2022

Alas github (and I guess gitlab too from work reasons) doesn't have "I want this comment to be pointed out because it needs further discussion so I don't want to immediately resolve it, but I don't want it to be blocking to the pR"

@david-christiansen
Copy link
Collaborator Author

Alas github (and I guess gitlab too from work reasons) doesn't have "I want this comment to be pointed out because it needs further discussion so I don't want to immediately resolve it, but I don't want it to be blocking to the pR"

I'm not sure what you mean by this one - can you rephrase?

@PPKFS
Copy link
Contributor

PPKFS commented Jun 14, 2022

The point about unicode characters was very interesting, and I think it's excellent that it's covered. However, it strikes me as strange that this is the error it throws.

Co-authored-by: PrettyPrincessKitty FS <thecommunistduck@hotmail.co.uk>
@david-christiansen
Copy link
Collaborator Author

I agree that it's a strange error, but documenting strange errors is at least as important as documenting non-strange ones :-)

@PPKFS PPKFS merged commit f257850 into main Jun 14, 2022
@PPKFS PPKFS deleted the GHC-24180 branch June 14, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants