Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce search delay #515

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

alt-romes
Copy link
Contributor

@alt-romes alt-romes commented Jun 15, 2022

Reduces the delay to 75ms. It still isn't instantaneous (hopefully not too jumpy), but the search doesn't feel actually slow anymore.

We can revise this number after using it as this for some time

Fixes haskellfoundation/error-message-index#328

@david-christiansen
Copy link
Collaborator

Out of curiosity, where does 75ms come from? Did you try 0ms or 5ms and find that there were problems?

@alt-romes
Copy link
Contributor Author

Out of curiosity, where does 75ms come from? Did you try 0ms or 5ms and find that there were problems?

Just addressing your concern of "jumpiness". 75ms is enough so that it doesn't feel terribly slow anymore -- that's my main concern. If you think then we can do with a fast, perhaps "jumpy" solution, we can reduce it further.

I don't think there was a problem, no, but I can see how someone would prefer a little bit of a pause.

@david-christiansen
Copy link
Collaborator

Let's give it a shot - we can always modify it again later, after all. Thanks!

@david-christiansen david-christiansen merged commit 029e9f4 into haskell:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very slow search
2 participants