Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fgl-5.6.0.0 fails with ghc-8.6.1 #81

Closed
juhp opened this issue Sep 25, 2018 · 10 comments
Closed

fgl-5.6.0.0 fails with ghc-8.6.1 #81

juhp opened this issue Sep 25, 2018 · 10 comments

Comments

@juhp
Copy link

juhp commented Sep 25, 2018

Just a heads-up that fgl fails to build with ghc-8.6.1:

Data/Graph/Inductive/Monad.hs:59:36: error:
    • Could not deduce (Control.Monad.Fail.MonadFail m)
        arising from a do statement
        with the failable pattern ‘(Just c, g')’
      from the context: GraphM m gr
        bound by the class declaration for ‘GraphM’
        at Data/Graph/Inductive/Monad.hs:42:20-25
      Possible fix:
        add (Control.Monad.Fail.MonadFail m) to the context of
          the type signature for:
            matchAnyM :: forall a b. m (gr a b) -> m (GDecomp gr a b)
          or the class declaration for ‘GraphM’
    • In a stmt of a 'do' block: (Just c, g') <- matchM v g
      In the expression:
        do (Just c, g') <- matchM v g
           return (c, g')
      In a case alternative:
          (v, _) : _
            -> do (Just c, g') <- matchM v g
                  return (c, g')
   |
59 |                      (v,_):_ -> do (Just c,g') <- matchM v g
   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^
@peti
Copy link

peti commented Sep 27, 2018

We've run into the same problem both in NixOS and in openSUSE. A fix would be very much appreciated.

@peti
Copy link

peti commented Sep 27, 2018

I believe that #80 would fix this issue.

@phadej
Copy link
Contributor

phadej commented Sep 30, 2018

I made revisions. Unfortunately there doesn't seem to be a GHC-8.6 compatible release atm.

https://matrix.hackage.haskell.org/package/fgl is green however (but only dark green for 8.6.1)

@recursion-ninja
Copy link
Contributor

@peti #80 is intended to fix this issue. There one last decision to be made as to how to resolve the MonadFail constraint requirement on the GraphM typeclass. I'm hoping that #80 is ready to be merged and the new version can be uploaded to hackage very soon.

@ivan-m ivan-m closed this as completed Nov 13, 2018
@peti
Copy link

peti commented Nov 15, 2018

I see #80 has been merged a few days ago. Is there going to be a new release?

@ivan-m
Copy link
Contributor

ivan-m commented Nov 15, 2018

Travis-CI builds are currently failing; once they work I'll release.

@juhp
Copy link
Author

juhp commented Nov 15, 2018

Looks good with #83 :-)

@phadej
Copy link
Contributor

phadej commented Nov 16, 2018

Or #84

@phadej
Copy link
Contributor

phadej commented Nov 24, 2018

ping @ivan-m

@ivan-m
Copy link
Contributor

ivan-m commented Nov 26, 2018

Done. Apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants