Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The insMapEdge family of functions are partial #98

Closed
TOTBWF opened this issue Mar 30, 2021 · 1 comment
Closed

The insMapEdge family of functions are partial #98

TOTBWF opened this issue Mar 30, 2021 · 1 comment

Comments

@TOTBWF
Copy link

TOTBWF commented Mar 30, 2021

The insMapEdge family of functions are partial, and will crash when you try to add an edge where one of the nodes doesn't exist in the graph. This doesn't appear to be documented anywhere. Perhaps it would make sense to either return a Maybe, or at the very least make this a no-op.

@TOTBWF TOTBWF changed the title The insMapEdge family of functions are partial, The insMapEdge family of functions are partial Mar 31, 2021
@athas
Copy link
Contributor

athas commented Oct 17, 2023

Changing the type would break compatibility, which I am reluctant to do, but we can at least document that they are partial.

@athas athas closed this as completed in 7a6a57e Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants