Make shortest-path functions safer. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely: - return `Nothing` instead of failing with the dreaded `*** Exception: Prelude.head: empty list` (for `spLength`) or returning non-sense (for `sp`) when the source is not connected to the destination. - mention in the docs that negative edge weights will not produce the right answer. - add tests that check that `Nothing` and `Just` are returned when they should be for shortest-path operations.
|
Thanks! |
|
You're welcome; thanks for maintaining the library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely:
return
Nothinginstead of failing with the dreaded*** Exception: Prelude.head: empty list(forspLength) or returningnon-sense (for
sp) when the source is not connected to thedestination.
mention in the docs that negative edge weights will not produce the
right answer.
add tests that check that
NothingandJustare returned whenthey should be for shortest-path operations.
I just used your great library for the first time but wasted time with
Prelude.head: empty listfromspLength. This patch will avoid that problem for future users.