Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tasty-bench package itself - [opened] #108

Closed
hasufell opened this issue Jul 1, 2022 · 3 comments
Closed

Use tasty-bench package itself - [opened] #108

hasufell opened this issue Jul 1, 2022 · 3 comments

Comments

@hasufell
Copy link
Member

hasufell commented Jul 1, 2022

In GitLab by @Bodigrim on Jul 1, 2022, 08:21

Merges tasty-bench -> master

As discussed at Bodigrim/tasty-bench#35 (comment), Windows build runs fine out of the box now.

@hasufell
Copy link
Member Author

hasufell commented Jul 1, 2022

In GitLab by @maerwald on Jul 2, 2022, 06:20

This introduces a dependency on tasty, which itself depends on optparse-applicative, which then pulls in all sorts of things. The package currently does not depend on tasty.

I'm not sure this is an improvement dependency-wise?

@hasufell
Copy link
Member Author

hasufell commented Jul 1, 2022

In GitLab by @Bodigrim on Jul 2, 2022, 07:18

You are the boss, you decide :) No hard feelings.

I don't see depending on tasty as a downside: pretty much every other boot package uses it. Using a well-known framework eases new contributions. It's also more flexible (like, you can add inspection tests) and featurefull (e. g., you can run only a failing test or only a certain group of tests; test suite is not limited to a flat list).

And using full-fledged tasty-bench is even more valuable in my experience. Not only it is significantly less code for you to maintain, but it gives an ability to compare against baseline or use bcompare. I find these features invaluable for an actionable performance analysis.

@hasufell
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant