New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tasty-bench package itself #181
Conversation
So does tasty-bench still depend on optparse-applicative? Can we have a lighter version? |
We would not be able to avoid |
If you rebase against master and then push to this repo instead of your fork, we can benefit from the fixed CI. |
|
It seems to be doing ok, no? |
I guess that makes sense. The benchmark info on CI won't be very useful. |
This is quite interesting:
In general, windows on 9.4.4 seems not very reliable, e.g. https://gitlab.haskell.org/ghc/ghc/-/issues/21990 |
The only FFI in I'll try to reproduce next week, once I get to my Windows machine. |
I am able to reproduce the access violation locally on Windows. Some obversations:
|
@Bodigrim this is a problem... tasty-bench depends on tasty, which depends on ansi-terminal, which depends on Win32 explicitly. The inlined version does not have this problem. |
69939aa
to
4b02664
Compare
cd4a763
to
2cd5cfc
Compare
Thanks to @mpilgrem, this is now solved: Non-moving GC seems to be solidly broken on Windows though. FWIW since |
I'm fine with disabling it, either on windows or in general. |
CI passes. Is this still considered a Draft? |
@hasufell ready for review now. |
Resurrecting #108.
The immediate reason is that your fork of
tasty-bench
is susceptible to Bodigrim/tasty-bench#44, which has been fixed upstream.There is also an ongoing effort to monitor performance of core libraries between GHC releases, but not using the standard tooling means that
filepath
is likely to miss out. E. g., there is no comparison between runs available, no filtering by patterns, no easy way to swaptasty-bench
fortasty-papi
/tasty-perfbench
to count CPU instructions.