Split internals into their own package #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
force-pushed
the
filepath-internals
branch
2 times, most recently
from
2feb76e
to
41038d8
Compare
hasufell
force-pushed
the
filepath-internals
branch
2 times, most recently
from
456228a
to
1293649
Compare
hasufell
force-pushed
the
filepath-internals
branch
from
1293649
to
9c9691c
Compare
Bodigrim
reviewed
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filepath-internalspackageunsafeFromBytesin public API (previouslyfromBytes)System.OsString.Internal.TypestoSystem.OsString.Types.InternalSystem.OsPath.Windows.InternalandSystem.OsPath.Posix.InternalPoint 2. and 4. were mostly done so that I don't have to move the entire implementation into
filepath-internals. If we want to avoid those changes... this PR will become much more involved.Also: strictly speaking, this change is not PVP compliant.