Configure POSIX resource limits using ulimit #2
Conversation
|
I have tested this for the past several weeks on my SmartOS builders and seen no direct ill effects. The most obvious side-effect this would have is not preventing runaway memory usage. I have the boundaries of my zones and ulimit in place for that. |
|
In practice the 1GB memory limit causes out of memory failures on 64-bit builds of GHC 7.8+. This makes the limit problematic. I considered making it configurable and then realized it is configurable via ulimit so there is no need. |
|
shouldn't there be some large but finite baked in limit still? Wouldn't eg a 10gb limit be a good "prevent explosions" limit that is far more than is needed for a ghc build (even in a 40core system?) but still some notion of limits? |
|
I'm going to add some explanation of ulimit to the README so people can easily constrain how far the builder can go. |
Alain's solution can do the same -- it is just not handled by
Sounds good to me. |
This amounts to removing the explicit handling since the resource limits already work if provided by the system. I believe this draws the correct boundary since I don't believe it is appropriate for the builder-client to set its own resource limits.
|
Okay documentation provided. I also put in a reference to Windows System Resource Manager since we likely want builders on Windows at some point soon. |
|
anything else needed to merge it in? Q: should we consider hackagifying it at some point? |
|
I think it's all good for merge. A: I like the idea of putting it on Hackage. We need a backlog of gaps between us and that eventuality so I can start filling them. |
Configure POSIX resource limits using ulimit
This amounts to removing the explicit handling since the resource limits
already work if provided by the system.
I believe this draws the correct boundary since I don't believe it is
appropriate for the builder-client to set its own resource limits.