Move library modules to src/ #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2017 07:03
The motivation behind this change is to
* avoid unnecessary recompilation for lib, exe, and tests
* fix the warning stack prints like below
Warning: The following modules should be added to exposed-modules
or other-modules in /Users/maoe/src/github.com/haskell/ghc-events/ghc-events.cabal:
- In ghc-events component:
GHC.RTS.EventParserUtils
GHC.RTS.EventTypes
GHC.RTS.Events
GHC.RTS.Events.Analysis
GHC.RTS.Events.Analysis.Capability
GHC.RTS.Events.Analysis.SparkThread
GHC.RTS.Events.Analysis.Thread
GHC.RTS.Events.Merge
GHC.RTS.EventsIncremental- In test-versions component:
GHC.RTS.EventParserUtils
GHC.RTS.EventTypes
GHC.RTS.Events
GHC.RTS.EventsIncremental
Utils- In write-merge component:
GHC.RTS.EventParserUtils
GHC.RTS.EventTypes
GHC.RTS.Events
GHC.RTS.EventsIncremental
Utils
|
Well spotted. LGTM. |
|
Good job! |
|
I believe this is not controversial and I've confirmed threadscope builds fine with this. I'm going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this change is to