mtl->transformers replacement, supporting transformers 0.3 (ErrorT) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rebased to upstream/master on 2014 10 22) This patch brings in all changes required to parse eventlogs generated by the Parallel Haskell system extending GHC. In particular, events for machine instances in a compute cluster and parallel process management are added; as well as some event variants necessary for the Eden Trace Viewer, a tool to analyse and view parallel execution traces.
Ignore-this: 805674f9d2e9156abf0b6980402c8756 darcs-hash:20120115204620-34406-3c170a97e5fb6a00b3fdac03b99c56daf8d2f336
Ignore-this: 4c22b862b8fec0bcb4a3b639e6dae49f darcs-hash:20140414194106-94b0f-71389ad625bb752b2379545b65e3143a0765bdfd
This patch follows the bugfix T9003 of GHC, enabling ghc-events to distinguish the GHC version that produced the eventlog and to correctly decode the thread stop status (which was encoded wrong in ghc-7.8.2). See T9003 for further discussion.
+ corrections in comments (rebased to upstream/master on 2014 10 22)
The change to transformers required only a few "lift". Replacing ErrorT by ExceptT is just as easy, allowing for a simple CPP solution to support both. Version number was increased to 0.5.0.1 (the package now has changed dependencies, which requires a major version bump according to policy)
|
I don't think this one is necessary because I intend to clean up and PR my incremental parser soon that should not depend on mtl nor transformers at all. |
|
Closing this because the changes are already in master and/or are superseded by #13. |
Mikolaj
pushed a commit
that referenced
this pull request
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a patch to replace ErrorT by ExceptT, but another one was provided to ghc-events just last week.
Therefore, I have separated one patch which provides code to replace mtl by transformers (which implements ExceptT), and uses supports both ErrorT and ExceptT (Cabal-generated version information and #ifdef).
/ Jost