Implement Goto Type Definition

[mpickering]

The test fails for some reason locally but works in the editor so if someone knows how to fix it then please tell me.

[cocreature]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[cocreature]

Looks great, thank you! HLint is currently failing due to a redundant $ and the indentation in nameToLocation seems off. Sadly Azure seems to have deleted the old CI logs. I’ll take a look at the test failures once we get past the hlint failures.

[cocreature]

The indentation here seems a bit excessive.

[cocreature]

This has a merge conflict in AtPoint.hs.

[mpickering]

I have no idea how the tests work at the moment as they don't even typecheck? I fixed that and then see this log:

HIE
  get
    type-definition
      Saturated data con:   ghcide version: 0.1.0 (GHC: 8.8.3) (PATH: /home/matt/ghcide-clean/dist-newstyle/build/x86_64-linux/ghc-8.8.3/ghcide-0.1.0/x/ghcide/build/ghcide/ghcide) (GIT hash: e231f7a0bc5f52bc3de1c5d4659274b7ba57d6d5)
Starting LSP server...
If you are seeing this in a terminal, you probably should have run ghcide WITHOUT the --lsp option!
 Started LSP server in 0.00s
[DEBUG] Set files of interest to: [NormalizedFilePath "/run/user/1000/extra-dir-58388217296644/GotoHover.hs"]
[DEBUG] Starting shakeRun (aborting the previous one took 0.00s)
[INFO] Opened text document: file:///run/user/1000/extra-dir-58388217296644/GotoHover.hs
[INFO] Files created or deleted: [(NormalizedFilePath "/run/user/1000/extra-dir-58388217296644/GotoHover.hs",True)]
[DEBUG] Starting shakeRun (aborting the previous one took 0.00s)
[DEBUG] Finishing shakeRun (took 0.00s, exception: AsyncCancelled)
[INFO] TypeDefinition request at position 19:21 in file: /run/user/1000/extra-dir-58388217296644/GotoHover.hs
[DEBUG] Finishing shakeRun (took 0.00s, exception: AsyncCancelled)
[DEBUG] Starting shakeRun (aborting the previous one took 0.00s)
[DEBUG] Running cradle /run/user/1000/extra-dir-58388217296644
"success"
"success"
"success"
[DEBUG] Finishing shakeRun (took 0.14s, completed)

But the server never sends a response to the TypeDefinition request.

At this point, I am not going to look into it further as it seems like a deep rabbit hole not really concerned with this patch.

[mpickering]

I have fixed the tests and identified two bugs in lsp-test in the process..

[mpickering]

CI is green now, this is ready to merge.

[cocreature]

Thank you!