This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Handle multiple user actions concurrently #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks suspiciously similar to some of @mpickering's code I deleted from the stale info PR :) What about your patch to handle requests concurrently? I've been feeling lack of that lately. |
Did he implement this too? Great minds think alike. Please share the link so that I can check if anything's missing.
I haven't looked into that yet. |
rayshih
reviewed
Aug 13, 2020
rayshih
approved these changes
Aug 16, 2020
pepeiborra
force-pushed
the
unlimited-recurse
branch
2 times, most recently
from
dc8cc64
to
8c73712
Compare
pepeiborra
force-pushed
the
unlimited-recurse
branch
from
8c73712
to
b289b7a
Compare
wz1000
reviewed
Sep 3, 2020
wz1000
approved these changes
Sep 3, 2020
pepeiborra
force-pushed
the
unlimited-recurse
branch
3 times, most recently
from
f21edd9
to
9f56f99
Compare
pepeiborra
force-pushed
the
unlimited-recurse
branch
from
ac844ad
to
d6797f8
Compare
Instead of creating a new TQueue on every restart, we reuse the same TQueue over and over. The trickiest bit is to ensure that enqueued actions are always retried when a Shake session is cancelled. The ActionQueue datatype is intended to manage this complexity.
Unfortunately these are dependent on the ghc version
These tests are failing because ghcide is sending diagnostics interleaved with completions now (which is good) and the tests cannot handle it
pepeiborra
force-pushed
the
unlimited-recurse
branch
from
d6797f8
to
a5aa82d
Compare
1 task
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* tighten some return types * Extract ShakeQueue from shakeSession Instead of creating a new TQueue on every restart, we reuse the same TQueue over and over. The trickiest bit is to ensure that enqueued actions are always retried when a Shake session is cancelled. The ActionQueue datatype is intended to manage this complexity. * Handle multiple user actions concurrently * Fixes for .ghci Unfortunately these are dependent on the ghc version * redundant parens * Formatting * Attempt fix for completion tests These tests are failing because ghcide is sending diagnostics interleaved with completions now (which is good) and the tests cannot handle it * remove debugging printout * simplify * Fix a test * Fix flaky tests
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* tighten some return types * Extract ShakeQueue from shakeSession Instead of creating a new TQueue on every restart, we reuse the same TQueue over and over. The trickiest bit is to ensure that enqueued actions are always retried when a Shake session is cancelled. The ActionQueue datatype is intended to manage this complexity. * Handle multiple user actions concurrently * Fixes for .ghci Unfortunately these are dependent on the ghc version * redundant parens * Formatting * Attempt fix for completion tests These tests are failing because ghcide is sending diagnostics interleaved with completions now (which is good) and the tests cannot handle it * remove debugging printout * simplify * Fix a test * Fix flaky tests
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* tighten some return types * Extract ShakeQueue from shakeSession Instead of creating a new TQueue on every restart, we reuse the same TQueue over and over. The trickiest bit is to ensure that enqueued actions are always retried when a Shake session is cancelled. The ActionQueue datatype is intended to manage this complexity. * Handle multiple user actions concurrently * Fixes for .ghci Unfortunately these are dependent on the ghc version * redundant parens * Formatting * Attempt fix for completion tests These tests are failing because ghcide is sending diagnostics interleaved with completions now (which is good) and the tests cannot handle it * remove debugging printout * simplify * Fix a test * Fix flaky tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on the single thread pumping user actions right now