This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Fix issue #710: fix suggest delete binding #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rayshih
changed the title
5 tasks
pepeiborra
approved these changes
Aug 15, 2020
|
Merged, thank you Ray! |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…ide#728) * [CodeAction] reimplement suggestDeleteBinding * [CodeAction] handle whole line removal for suggestDeleteUnusedBinding * [CodeAction] add test for bug haskell/ghcide#710 * [CodeAction] add more tests for suggesting unused binding * fix hlint warnings * fix hlint warnings * remove unused imports * fix compilation problem for 8.4 * remove redundant pattern matching * reconcile the disagreement of a pattern matching is redundant
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…ide#728) * [CodeAction] reimplement suggestDeleteBinding * [CodeAction] handle whole line removal for suggestDeleteUnusedBinding * [CodeAction] add test for bug haskell/ghcide#710 * [CodeAction] add more tests for suggesting unused binding * fix hlint warnings * fix hlint warnings * remove unused imports * fix compilation problem for 8.4 * remove redundant pattern matching * reconcile the disagreement of a pattern matching is redundant
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…ide#728) * [CodeAction] reimplement suggestDeleteBinding * [CodeAction] handle whole line removal for suggestDeleteUnusedBinding * [CodeAction] add test for bug haskell/ghcide#710 * [CodeAction] add more tests for suggesting unused binding * fix hlint warnings * fix hlint warnings * remove unused imports * fix compilation problem for 8.4 * remove redundant pattern matching * reconcile the disagreement of a pattern matching is redundant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By generalizing code action: suggestions of delete unused top binding to suggestions of delete unused binding.
This is basically a reimplementation which traverses the AST.