Allow to specify a build config for 'ghcup compile' #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
force-pushed
the
PR/allow-to-specify-build-config
branch
from
c8d2e5a
to
ecbd47c
Compare
hasufell
changed the title
hvr
approved these changes
Oct 16, 2018
| -f, --force Overwrite already existing installation | ||
| -j, --jobs <n> How many jobs for compilation | ||
| -c, --build-config <filepath> Use the given config file as build config | ||
| (mk/build.mk) |
There was a problem hiding this comment.
Btw, at first, the "(mk/buiild.mk)" seemed a bit confusing to me, as I wrongly assumed that'd be the default <filepath>
| edo cat "${build_config}" > mk/build.mk | ||
| else | ||
| cat <<-EOF > mk/build.mk || die | ||
| BuildFlavour = quick |
There was a problem hiding this comment.
btw, BuildFlavour = quick won't have any effect, that's not how that var works... (nor would it be a good idea to use that build-profile even if it worked)
|
merged and fixed as 69e2060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19