-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce and use a meta file format for URLs and available versions #28
Conversation
a74a2b9
to
0248c4b
Compare
TODO:
|
1cf2ff5
to
67fd774
Compare
I'm not sure allowing full control over downloader is a good thing. Maybe this should rather be a simple switch. |
I still think that using a gist to host the metadata is not a good idea, as it makes it harder for people contribute to the metadata via GitHub PRs nor is it integrated well with the GitHub issue tracker workflow. |
The gist is only temporary, so I can test changes more easily. |
If there is no further comment, then I will merge this soon. |
961edea
to
26bd198
Compare
I tried this on a macOS box, and this made me realise that the metadata files seem to imply Linux as the OS; imo, we either need to encode the OS (linux, windows, darwin, freebsd, ...) as separate dimension, or we need to account for different per-OS flavours of " btw, some prior art exists in Autoconf's target triples:
where you typically have something like
but that's not ideal for ghcup either, as it doesn't include the distro name/release there's also https://wiki.debian.org/Multiarch/Tuples which shows the extent of the configuration space possible even with only just Debian. |
I don't think it's necessary to delay this further. Mac support can be done in a later PR. The file format is versioned.
…On October 30, 2018 11:30:00 AM UTC, Herbert Valerio Riedel ***@***.***> wrote:
I tried this on a macOS box, and this made me realise that the metadata
files seem to imply Linux as the OS; imo, we either need to encode the
OS (linux, windows, darwin, freebsd, ...) as separate dimension, or we
need to account for different per-OS flavours of "`unknown`"
distributions
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#28 (comment)
|
fine by me; this PR certainly doesn't make things worse than before :-) |
26bd198
to
c1f7ce7
Compare
Fixes #21
Fixes #9
Fixes #10
Fixes #5
Not supposed to be merged right now since it's not clear where we want to host those meta info files.
Files are currently here: https://gist.github.com/hasufell/71bf6cf0d3606d5b9a71c633940610bf