Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce and use a meta file format for URLs and available versions #28

Merged
merged 6 commits into from
Oct 30, 2018

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Oct 17, 2018

Fixes #21
Fixes #9
Fixes #10
Fixes #5

Not supposed to be merged right now since it's not clear where we want to host those meta info files.

Files are currently here: https://gist.github.com/hasufell/71bf6cf0d3606d5b9a71c633940610bf

@hasufell hasufell requested a review from hvr October 17, 2018 17:07
@hasufell hasufell force-pushed the PR/meta-file-format branch 3 times, most recently from a74a2b9 to 0248c4b Compare October 18, 2018 02:45
@hasufell
Copy link
Member Author

hasufell commented Oct 18, 2018

TODO:

@hasufell hasufell force-pushed the PR/meta-file-format branch 2 times, most recently from 1cf2ff5 to 67fd774 Compare October 18, 2018 16:30
@hasufell
Copy link
Member Author

I'm not sure allowing full control over downloader is a good thing. Maybe this should rather be a simple switch.

@hvr
Copy link
Member

hvr commented Oct 22, 2018

I still think that using a gist to host the metadata is not a good idea, as it makes it harder for people contribute to the metadata via GitHub PRs nor is it integrated well with the GitHub issue tracker workflow.

@hasufell
Copy link
Member Author

The gist is only temporary, so I can test changes more easily.

@hasufell
Copy link
Member Author

If there is no further comment, then I will merge this soon.

@hasufell hasufell force-pushed the PR/meta-file-format branch 5 times, most recently from 961edea to 26bd198 Compare October 30, 2018 10:57
@hvr
Copy link
Member

hvr commented Oct 30, 2018

I tried this on a macOS box, and this made me realise that the metadata files seem to imply Linux as the OS; imo, we either need to encode the OS (linux, windows, darwin, freebsd, ...) as separate dimension, or we need to account for different per-OS flavours of "unknown" distributions (e.g. linux-unknown);

btw, some prior art exists in Autoconf's target triples:

Autoconf-generated configure scripts can make decisions based on a canonical name for the system type, or target triplet, which has the form: cpu-vendor-os, where os can be ‘system’ or ‘kernel-system’

where you typically have something like

  • x86_64-unknown-linux
  • x86_64-unknown-linux-gnu (kernel = Linux, system = GNU)

but that's not ideal for ghcup either, as it doesn't include the distro name/release

there's also https://wiki.debian.org/Multiarch/Tuples which shows the extent of the configuration space possible even with only just Debian.

@hasufell
Copy link
Member Author

hasufell commented Oct 30, 2018 via email

@hvr
Copy link
Member

hvr commented Oct 30, 2018

fine by me; this PR certainly doesn't make things worse than before :-)

@hasufell hasufell merged commit c1f7ce7 into master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants