Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a GHCUP_INSTALL_BASE_PREFIX #60

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Introduce a GHCUP_INSTALL_BASE_PREFIX #60

merged 1 commit into from
Dec 14, 2018

Conversation

hasufell
Copy link
Member

Partly "fixes" #7

@hasufell
Copy link
Member Author

@Franciman

@Franciman
Copy link

Great, thank you very much!

@hasufell
Copy link
Member Author

Can you test it?

@Franciman
Copy link

Ok I tested all commands, they all seem to be working correctly.

Franciman
Franciman reviewed Dec 13, 2018
View reviewed changes
ghcup
# configurable via the environment variable of the
# same name. It must be non-empty and the path
# it points to must exist.
: "${GHCUP_INSTALL_BASE_PREFIX:=$HOME}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest replacing this line with the following?

GHCUP_INSTALL_BASE_PREFIX="${GHCUP_INSTALL_BASE_PREFIX:-$HOME}"

It seems to me less cryptic and more similar in style to other variables definitions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is normal shell syntax

@hasufell hasufell merged commit 75e48da into master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Franciman Franciman Franciman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hasufell @Franciman