Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghcup www, design from rustup #78

Merged
merged 3 commits into from
Mar 23, 2019
Merged

Add ghcup www, design from rustup #78

merged 3 commits into from
Mar 23, 2019

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Mar 22, 2019

Already uploaded for testing: https://www.haskell.org/ghcup/

@hasufell hasufell requested review from hvr and gbaz March 22, 2019 04:37
@gbaz
Copy link
Contributor

gbaz commented Mar 22, 2019

Honestly I don't see what it means to say "ghcup is an official Haskell project". Like, haskell.org hosts it now sure, so you could note that. But even ghc isn't an "official Haskell project" -- unlike rust there's no body (including the haskell.org committee) in a position to make such designations :-) Perhaps it could just say "ghcup is hosted by haskell.org".

Also, I visited from a mac and it said "You appear to be running Unix." Which, I guess, isn't exactly wrong, but nonetheless. It would maybe be better to say "Unix or OS X" or the like?

And finally, the "other installation options" should link to the downloads page, even though it remains a mess. The platform page now just recommends ghcup for linux (and will probably soon do so for os x) so it'll create a link cycle.

@hasufell
Copy link
Member Author

It would maybe be better to say "Unix or OS X" or the like?

I find that a bit confusing. It's like guessing :)

The js code is able to detect this, but what is the value of this distinction? It's a unix-like system, we probably have POSIX and that's all we need to know...

@hasufell
Copy link
Member Author

I also noticed the page looks funny if JS is disabled in the browser.

@hasufell hasufell added the www www.haskell.org/ghcup related issues label Mar 22, 2019
@gbaz
Copy link
Contributor

gbaz commented Mar 22, 2019

The js code is able to detect this, but what is the value of this distinction? It's a unix-like system, we probably have POSIX and that's all we need to know...

Sure its all we need to know, but it would be confusing to many users, who really don't think of OS X as a unix, and hence would be confused by text saying they were running unix, and perhaps think that there was a mistake.

@dwijnand
Copy link
Contributor

Maybe just mirror Rustup and say "It looks like you’re running macOS, Linux, or another Unix-like OS." (or keep the "You appear to be running" start).

@hasufell
Copy link
Member Author

Should be all fixed now.

@llelf
Copy link
Member

llelf commented Mar 23, 2019

Also, I visited from a mac and it said "You appear to be running Unix." Which, I guess, isn't exactly wrong

Piece of useless esoterica: from all mentioned OS in the commit, Mac OS is the only one that can be called UNIX® (because it's UNIX® certified™).

@hasufell hasufell merged commit afe5670 into master Mar 23, 2019
@hasufell
Copy link
Member Author

@gbaz people have been raising concerns about the visibility of the page https://www.reddit.com/r/haskell/comments/b4kcfg/ghcup_homepage_now_at_haskellorg/ej9karl/?context=3

At least https://www.haskell.org/platform/#linux-generic should probably point to the new homepage now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
www www.haskell.org/ghcup related issues
Projects
None yet
4 participants