Tweak ghcup upgrade

[hasufell]

1. add --inplace flag
2. by default install into BIN_LOCATION

[fommil]

I'll try to remember to us -i the time after the next time I call it 😄

[hasufell]

I'll try to remember to us -i the time after the next time I call it

I don't even understand the use case exactly...

Also @Franciman would that break anything?

[fommil]

As I understand it, the current default behaviour changes and I must provide -i to update the script inplace... or did I misunderstand? I'd obviously prefer that inplace was the default but I assume you have reasons why this is not good, and I am fine typing two extra characters.

[Franciman]

Hi, thanks for noticing me, it won't break anything on vabal side, as soon as ghcup stays in PATH.

[fommil]

my ghcup is in PATH too so maybe this doesn't affect me, I guess this might only matter if the script is called explicitly?

[hasufell]

The default behavior now is:

1. upgrade into ${GHCUP_INSTALL_BASE_PREFIX:=$HOME}/.ghcup
2. if passed --inplace will upgrade at the location of where the script is at (wherever that is)
3. if invoked ghcup upgrade <some-dir> then will place it there

Is that too confusing?

[fommil]

ok thats' what I thought from reading the source code, the comments here confused me. I might move my script location to ~/.ghcup/bin just to make this easier to manage.