Introduce print-system-reqs wrt #49 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
force-pushed
the
system-reqs
branch
2 times, most recently
from
8b125f8
to
746da09
Compare
|
A problem with this approach is that we have to install ghcup prior to checking the requirements, which might already fail on missing stuff that is vital to the script itself (not ghc): https://github.com/haskell/ghcup/blob/master/ghcup#L1824 But since bootstrap-haskell can be rerun at any given time I think this is good enough. |
|
@phadej this needs your review |
phadej
approved these changes
Apr 10, 2019
.requirements/ghc/ubuntu
Outdated
| @@ -0,0 +1 @@ | |||
| autoconf automake curl g++ gcc git libgmp-dev libllvm5.0 libtinfo-dev libtool llvm-5.0 llvm-5.0-dev make ncurses-dev python3 realpath xz-utils | |||
There was a problem hiding this comment.
I wonder about llvm: the versions vary with each GHC, and most users don't need it. I'd drop that.
Also it seems that these are requirements to build the ghc, not only use it. Though most are reasonable to have. (E.g. git is quite optional :)
And also make bootstrap-haskell print this by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also make bootstrap-haskell print this by default.